Sal Ferrarello

Results 75 comments of Sal Ferrarello

Correction, the issue was at the `sm` breakpoint, not `md`. Issue title changed to reflect this.

I think you are both right that ``` 'content' => 'col-sm-8 col-md-9', 'sidebar-primary' => 'col-sm-4 col-md-3', ``` is a significant improvement. I realized that while making this change, it makes...

Branch `change-cols-108` has the potential change for this default value. For adjusting the other layouts, I've opened #119

Currently this project is using spaces instead of tabs. See the [.editorconfig file](https://github.com/salcode/bootstrap-genesis/blob/develop/.editorconfig). We want to keep the project consistent so I'd ask that you either change to spaces or...

Hi @vynnus, I think an off-canvas menu implementation would be awesome. However, it would be outside the scope of what I envision for this project. I can imagine this being...

`children` is a ReactJS prop that every component receives. It contains any values "inside" that component. e.g. If you are using JSX that looks something like ``` My Title My...

@ahmadawais, thanks for the quick reply. > Did you read the contribution guide I wrote. It's hacky but take a look. By "contribution guide", you're referring to [CONTRIBUTING.md](https://github.com/ahmadawais/create-guten-block/blob/master/CONTRIBUTING.md), correct? That...

@ahmadawais, thank you. This gives me a good path to go down (and feel better about it not working the way I expected). 👍 It is getting late here but...

+1 on `null` instead of empty string (`""`). I've updated the PR. Good catch @riyuk 👍

@srikat I generally like your changes. My only note here is I think there is a lot of value in having a canonical version of this plugin. @christophercochran I apologize...