Paul Sajna

Results 143 comments of Paul Sajna

![2021-12-11-195554_622x504_scrot](https://user-images.githubusercontent.com/1562711/145699665-995602fb-4347-4e22-9f40-9a6076347e11.png)

Here's the shitty code I wrote to convert the models: https://gist.github.com/sajattack/1f8961294f75df795473bc1231c4ce5b

> I think the crate needs more documentation in general. For example psp::sys::AudioInputParams has six variables, but only one of them has been named The docs were pulled in through...

There is a difference in what we have and what hlide says for vf2in and vi2f.

I left the remainder for you @overdrivenpotato because I'm not exactly sure how to do their encodings.

The list is what was missing when this PR was created, not a complete list, and the ones without checkmarks are what remain. I think it should be complete when...

> > There is a difference in what we have and what hlide says for vf2in and vi2f. > > What do you mean? I don't remember. Looks the same...

@overdrivenpotato should we close this?

Yeah, the main question was whether the work done here is transferrable to the new macro or if we need to just redo it.

Here's a sample implementation: (imagine it on this line of atsamd-hal https://github.com/atsamd-rs/atsamd/blob/2e71c08a952f9e5b1c1137a1277b8f61c14e9b04/hal/src/gpio.rs#L423) ```rust impl OutputPort for Port { fn write(&mut self, word: u32) { unsafe { (*PORT::ptr()).outset.write(|bits| { bits.bits(word) });...