Sajarin
Sajarin
@sabbiu what happens when you try to run the integration tests locally? (we can continue the conversation over on your PR, if that's preferred as well)
Fixed in https://github.com/airbytehq/airbyte/pull/23539
/test connector=connectors/destination-s3-glue > :clock2: connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/4086083786 > :white_check_mark: connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/4086083786 No Python unittests run > ### Build Passed Test summary info: ``` All Passed ```
@blarghmatey this looks good, the next steps here are to publish the connector and then merge it into master. I would run the action for the publishing but we have...
/test connector=connectors/destination-s3-glue > :clock2: connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/4115896229 > :white_check_mark: connectors/destination-s3-glue https://github.com/airbytehq/airbyte/actions/runs/4115896229 No Python unittests run > ### Build Passed Test summary info: ``` All Passed ```
/publish connector=connectors/destination-s3-glue > :clock2: Publishing the following connectors:connectors/destination-s3-gluehttps://github.com/airbytehq/airbyte/actions/runs/4116100405 | Connector | Did it publish? | Were definitions generated? | | --- | --- | --- | | connectors/destination-s3-glue | :white_check_mark:...
@blarghmatey looks like I can't push to your branch can you follow step 4 from the instructions linked above and generate the definitions by editing the destination.yaml file and running...
Thanks for the PR @blarghmatey and thanks for the review @itaseskii
Thanks for the PR, our team will take a look!
Hey @roisinbolt, it's on our team's backlog. Since Tiktok Marketing is a GA connector, it could take some time for a full review. Thanks for being patient!