airbyte
airbyte copied to clipboard
Source Pipedrive: fix connection check failure with no deals
What
Fixes this issue: https://github.com/airbytehq/airbyte/issues/21944, where the pipedrive source cannot be added if there are no deals present in the pipedrive instance.
How
Adds default to record read to avoid a StopIteration error when there are no records present.
🚨 User Impact 🚨
No breaking changes, will allow users to connect to Pipedrive if they don't have any deal records in their instance.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
- [x] Grant edit access to maintainers (instructions)
- [ ] Secrets in the connector's spec are annotated with
airbyte_secret - [ ] Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest. - [ ] Code reviews completed
- [ ] Documentation updated
- [ ] Connector's
README.md - [ ] Connector's
bootstrap.md. See description and examples - [ ] Changelog updated in
docs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog example
- [ ] Connector's
- [ ] PR name follows PR naming conventions
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
- [ ] Create a non-forked branch based on this PR and test the below items on it
- [ ] Build is successful
- [ ] If new credentials are required for use in CI, add them to GSM. Instructions.
- [ ]
/test connector=connectors/<name>command is passing - [ ] New Connector version released on Dockerhub and connector version bumped by running the
/publishcommand described here
Fixed in https://github.com/airbytehq/airbyte/pull/23539