Bendix Sältz

Results 23 comments of Bendix Sältz

Thanks for your comments! > NonEmptyList also lacks appendAll method. So I think that it would be nice to add them both simultaneously – appendAll and prependAll. Added that. >...

I'd also be interested to help.

Possibly duplicate of https://github.com/sksamuel/scapegoat/issues/391.

I dug a little into this: For Scala 2.13.10 in the ticket mentioned above, scoverage wasn't released yet. That has been resolved with scoverage 2.0.5. That helps us a bit...

Maybe @sksamuel has an opinion?

`PredefSeqIsMutable` is already disabled for Scala 2.13: https://github.com/sksamuel/scapegoat/blob/5c690f685632d4b784fb0a187ef0091ec395a233/src/main/scala/com/sksamuel/scapegoat/inspections/collections/PredefSeqIsMutable.scala#L16

It even fails on the very simple: ``` val list = None.get :: Nil ``` This is a `ValDef` in the macro, containing a `Block` tree type with the following...

@mccartney, any idea why this fails on Scala 2.12?

Thanks for taking a closer look! > we have much option beyond checking the variable name Implemented exactly that, ignoring underscores.