Scoverage failure

[mccartney]

See the Continuous Integration failure in https://github.com/scapegoat-scala/scapegoat/pull/681 Let's fix it going forward.

[saeltz]

I dug a little into this: For Scala 2.13.10 in the ticket mentioned above, scoverage wasn't released yet. That has been resolved with scoverage 2.0.5. That helps us a bit but brings up another issue: scoverage 2.x+ is a new major version that doesn't support Scala 2.11.x anymore. So we have three options:

1. Drop support for Scala 2.11.x (fine for me, nothing should block users to update to Scala 2.12.x)
2. Drop coverage from our CI (fine for me as well, as long as we demand tests for new inspections)
3. Have some if-else in sbt to use a different scoverage version for Scala 2.11.x than for 2.12+

Irregardless, for scoverage 2.x we would need to add a library dependency scheme to ignore the conflict in scala-xml that raises an error otherwise because version 2.x+ of scala-xml is used in the newer scoverage whereas we use 1.3.0 for Scala 2.11.x. Like this:

// sbt-scoverage plugin depends on scala-xml 2.x.x which is not available for Scala 2.11.x
libraryDependencySchemes += "org.scala-lang.modules" %% "scala-xml" % "always"

Your thoughts?

[saeltz]

Maybe @sksamuel has an opinion?

[jozic]

It seems dropping Scala 2.11 makes life easier for everyone, most likely people who stuck with 2.11 can't upgrade things much anyway Just my 2c

[sksamuel]

Yeah I'd say drop 2.11. It's years out of date at this point.

On Mon, Oct 17, 2022, 8:03 AM Eugene Platonov @.***> wrote:

It seems dropping Scala 2.11 makes life easier for everyone, most likely people who stuck with 2.11 can't upgrade things much anyway Just my 2c

— Reply to this email directly, view it on GitHub https://github.com/scapegoat-scala/scapegoat/issues/682#issuecomment-1280826815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGVQU55PYOMRT7SLJ5TWDVFATANCNFSM6AAAAAARBVPEII . You are receiving this because you were mentioned.Message ID: @.***>