Sandhya Dasu
Sandhya Dasu
/hold The updates to PlatformStatus have changed. See https://github.com/openshift/api/pull/1685.
/retest-required
/hold Updates to PlatformStatus have changed. See https://github.com/openshift/api/pull/1685.
@willie-yao could you please take another look? Thanks!
> Thanks for your work on this @sadasu! One small design suggestion: Would you be able to change the PrivateDNSZoneModes to a custom type definition like how [UpgradeChannel](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/5538d6694ffd59538ab91a535162e3f1f4ad0d1d/api/v1beta1/azuremanagedcontrolplane_types.go#L40) is defined...
> > This change is causing [pull-cluster-api-provider-azure-apidiff](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/5666/pull-cluster-api-provider-azure-apidiff/1948057193597112320) to fail. > > For what it's worth, that's not a required check. It's up to maintainers of a given project, but if...
@nrb and @willie-yao, upon further consideration, I decided to move `PrivateDNSZone` from [NetworkClassSpec](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/types_class.go#L457) to [NetworkSpec](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/types.go#L92) because within the `NetworkClassSpec`, the properties may be shared across multiple clusters. Moving it to...
> For example, a Vnet is not in `NetworkClassSpec` because the same Vnet cannot be shared by multiple clusters @willie-yao So, it appears that you agree with the move to...
/test pull-cluster-api-provider-azure-apiversion-upgrade