api icon indicating copy to clipboard operation
api copied to clipboard

CORS-3040: Add Azure platform status to indicate user provisioned DNS

Open jhixson74 opened this issue 2 years ago • 13 comments

This is a port of https://github.com/openshift/api/commit/40c7e9bd69ba859a60e7308229db8c4c8421c172 for Azure

jhixson74 avatar Nov 29 '23 17:11 jhixson74

Hello @jhixson74! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Nov 29 '23 17:11 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhixson74 Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 29 '23 17:11 openshift-ci[bot]

/test e2e-aws-ovn /test e2e-azure /test e2e-gcp

jhixson74 avatar Dec 02 '23 02:12 jhixson74

/test e2e-aws-serial-techpreview

jhixson74 avatar Dec 02 '23 02:12 jhixson74

/test verify

jhixson74 avatar Dec 02 '23 15:12 jhixson74

/test verify

sadasu avatar Dec 04 '23 13:12 sadasu

@jhixson74: This pull request references CORS-3040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

This is a port of https://github.com/openshift/api/commit/40c7e9bd69ba859a60e7308229db8c4c8421c172 for Azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot avatar Dec 05 '23 03:12 openshift-ci-robot

/retest

jhixson74 avatar Dec 05 '23 19:12 jhixson74

/retest

rna-afk avatar Dec 05 '23 22:12 rna-afk

/hold Updates to PlatformStatus have changed. See https://github.com/openshift/api/pull/1685.

sadasu avatar Jan 11 '24 23:01 sadasu

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Mar 19 '24 13:03 openshift-merge-robot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 18 '24 01:06 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Aug 11 '24 00:08 openshift-bot

@jhixson74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test verify-deps
ci/prow/unit 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test unit
ci/prow/integration 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test integration
ci/prow/verify-client-go 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test verify-client-go
ci/prow/build 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test build
ci/prow/verify-crd-schema 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test verify-crd-schema
ci/prow/e2e-azure 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link false /test e2e-azure
ci/prow/verify 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test verify
ci/prow/e2e-gcp 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link false /test e2e-gcp
ci/prow/images 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test images
ci/prow/e2e-aws-serial-techpreview 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-hypershift 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade-minor 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test e2e-upgrade-minor
ci/prow/e2e-upgrade 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test e2e-upgrade
ci/prow/minor-images 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test minor-images
ci/prow/minor-e2e-upgrade-minor 999480564994c1d1d9fd7f1e9e393f9ade2bdcc5 link true /test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 15 '24 15:08 openshift-ci[bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Sep 15 '24 00:09 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 15 '24 00:09 openshift-ci[bot]