Shunkichi Sato

Results 193 comments of Shunkichi Sato

https://github.com/hyperledger/iroha/issues/4278#issuecomment-1963549332 Thank you @0x009922 I think #4316 can be applied on the assumption that the templates will reflect actual configurations, which I noted in #4316

Closed as the rest of the issue will be left to #4288

Related discussions so far: - https://github.com/hyperledger/iroha/pull/4411#discussion_r1565403959 - https://github.com/hyperledger/iroha/pull/4411#discussion_r1568375676 - https://github.com/hyperledger/iroha/pull/4411#discussion_r1575812237

As of 2cf50c0da `I2::Dev::Tests / with_coverage` is failing due to `-p iroha_client --test mod` (client/tests/integration/). It seems to happen with the following combination: - `nightly-2024-04-18` - `RUSTFLAGS="-C instrument-coverage"` - `-p...

Updated, see [this comparison](https://github.com/hyperledger/iroha/compare/af55ee4c706e3491f5966b2e4799b62437eb3bc8..fd5a898e8e357c149926a0b26f039786ee817f26). The changes are as follows: - remove the 2nd commit: Auto-register destination account on transfer - fix pytest account structure - move `iroha_sample_params` directory to under...

Some discussions are now outside the scope of this PR, so they will be folded once and tracked in #4426

Just a thought, but for step 2, the following may be worth trying in an experimental repository: ```bash gh [issue|pr] list --search "-label:iroha2" | (extract numbers) | xargs -I {}...

It seems to me that with this change, Iroha will temporarily lose the feature of multi-signature transactions. Is that okay for you all? My concerns are noted here https://github.com/hyperledger/iroha/issues/4229#issuecomment-1958880901

Or we could just run locally as same consistency checks as CI does: https://github.com/hyperledger/iroha/blob/41c08b4310cdf3720756304360a979c378a8b6b0/.github/workflows/iroha2-dev-pr.yml#L28-L36 I basically think it's up to each developer to avoid failures on push, but as long...

One possibility is to stop deserializing to keys from config files or environment variables altogether and configure it only when sign-up (keys generation) or login