Automatic notification about config.json changes through CI
As we discussed with Vasily, it'll be much more convenient if he's notified about any possible configuration change. Ultimately, we concluded that it's best to have a CI utility that doesn't use any outside software and notifies him about the changes. It's not a priority and probably will be added in March 2024.
#4276 would be one of the possible solutions
This is a new feature introduced by #4276 to automatically label and notify someone of specific code changes. Currently
config-changesreacts to any change underconfigs/, which may be an inappropriate pattern. I guessconfigs/*.template.*would be correct one at the current directory structure. Since things may have changed after #4239 I'd hear your opinion @0x009922
#4309 (comment) This is a new feature introduced by #4276 to automatically label and notify someone of specific code changes. Currently
config-changesreactions to any change underconfigs/, which may be an inappropriate pattern. I guessconfigs/*.template.*would be correct one at the current directory structure. Since things may have changed after #4239 I'd hear your opinion @0x009922
Yeah, lets's update notifications, please. There should not be a false-positive notifications for DevOps.
Yes, I would say that configs/{client|peer}.template.toml is an exhaustive coverage to see if there are user-facing changes in the config.
However, these files aren't covered yet with tests to ensure that the config implementation actually reflects them. There is an issue for it: https://github.com/hyperledger/iroha/issues/4288
https://github.com/hyperledger/iroha/issues/4278#issuecomment-1963549332
Thank you @0x009922 I think #4316 can be applied on the assumption that the templates will reflect actual configurations, which I noted in #4316
Is it still relevant?
Closed as the rest of the issue will be left to #4288