iroha icon indicating copy to clipboard operation
iroha copied to clipboard

Automatic notification about config.json changes through CI

Open 6r1d opened this issue 1 year ago • 5 comments

As we discussed with Vasily, it'll be much more convenient if he's notified about any possible configuration change. Ultimately, we concluded that it's best to have a CI utility that doesn't use any outside software and notifies him about the changes. It's not a priority and probably will be added in March 2024.

6r1d avatar Feb 13 '24 08:02 6r1d

#4276 would be one of the possible solutions

s8sato avatar Feb 13 '24 09:02 s8sato

#4309 (comment)

This is a new feature introduced by #4276 to automatically label and notify someone of specific code changes. Currently config-changes reacts to any change under configs/, which may be an inappropriate pattern. I guess configs/*.template.* would be correct one at the current directory structure. Since things may have changed after #4239 I'd hear your opinion @0x009922

s8sato avatar Feb 22 '24 06:02 s8sato

#4309 (comment) This is a new feature introduced by #4276 to automatically label and notify someone of specific code changes. Currently config-changes reactions to any change under configs/, which may be an inappropriate pattern. I guess configs/*.template.* would be correct one at the current directory structure. Since things may have changed after #4239 I'd hear your opinion @0x009922

Yeah, lets's update notifications, please. There should not be a false-positive notifications for DevOps.

BAStos525 avatar Feb 22 '24 07:02 BAStos525

Yes, I would say that configs/{client|peer}.template.toml is an exhaustive coverage to see if there are user-facing changes in the config.

However, these files aren't covered yet with tests to ensure that the config implementation actually reflects them. There is an issue for it: https://github.com/hyperledger/iroha/issues/4288

0x009922 avatar Feb 26 '24 08:02 0x009922

https://github.com/hyperledger/iroha/issues/4278#issuecomment-1963549332

Thank you @0x009922 I think #4316 can be applied on the assumption that the templates will reflect actual configurations, which I noted in #4316

s8sato avatar Feb 26 '24 12:02 s8sato

Is it still relevant?

BAStos525 avatar Mar 19 '24 13:03 BAStos525

Closed as the rest of the issue will be left to #4288

s8sato avatar Mar 19 '24 15:03 s8sato