Sam Lanning

Results 44 comments of Sam Lanning

On enum value naming, perhaps `return-original` instead of `returnoriginal` would be better etc...?

Sorry for not responding sooner, been a busy couple of weeks for me! Glad to see that you've made progress with the CI checks and increasing strictness too! I've opened...

I've effectively implemented this in https://github.com/s0/museeks/blob/synesthesia/src/ui/lib/player.ts, as part of the work towards #31 (see https://github.com/martpie/museeks/issues/31#issuecomment-598853728). Hopefully I'll soon have a PR open that will address this issue and #31.

I've been playing around with the WebAudio API in Musseks for a slightly different reason (accurate timestamps for synchronizing audio with lighting with my synesthesia project), which it turned out...

This is also a useful article: http://dalecurtis.github.io/llama-demo/index.html

Made progress with updating my precise-audio library for gapless playback with a small POC in the browser. Seems to work relatively well in chrome when playing LAME encoded MP3 files:...

Hey, I see that PR integration seems to now have been resolved in #12166, sorry to hear that we'd silently been not analysing PRs. I have a few suggestions that...

@thomasjpfan Thanks for pointing that out. We've taken a look and have got the LGTM analysis working again now.

Further info on fixes here: #13044

@amueller could you elaborate? Builds and analysis seem to be working as far as i can see?