ryusmo

Results 41 comments of ryusmo

1. We use collection id on metadata to start metadata id from 1 per collection. If metadata id is used globally, collection creators won't know that what their metadata ids...

We delete previous NFT because, it has NFT information as well as NFT by owner keys. When set NFT is called on transfer NFT, only owner field will need to...

I think there should be fields that can be edited confirmed.

Here's the commit for genesis tests https://github.com/bitsongofficial/go-bitsong/pull/153/commits/b3d719ad03c305c9289e775f45c033cdb6dabcec Just have put genesis init and export functionalities on keeper, to follow latest Cosmos coding standard.

Yea, I agree on adding paginations for queries. I think we already have querying nfts by owner. `bitsongd query nft nfts-by-owner [owner]`

It's because of struct we have, do you like to make it to be consistent to have MaxSupply=1 for _normal_ NFT?

SetNFT is used on several places and I think it would be not ideal to write same check on several places.