ryusmo comments

Results 41 comments of


                                            ryusmo

DeleteNFT is used for internally when resetting NFT data, but this can be exposed via MsgServer to burn nft,

I think we can add metadata info on collection query.

Okay, new owner could be provided as part of create nft.

Okay, will make the suggested changes

This is done on this commit. https://github.com/bitsongofficial/go-bitsong/pull/153/commits/afcba32b4f1dfc1a6db7140b01d17eec347daf99

I think it's okay to emit event on msg server.

Owner address is verified on ValidateBasic fyi. Usually avoiding duplicated execution would be good.

1. ValidateBasic is executed on chain side as well not only client side 2. Okay - will make verifications for Owner part.

I think validate genesis is already executed before init genesis execution on SDK side.

Okay - new params could be added for print fee.