Ruiyang Wang

Results 78 comments of Ruiyang Wang

cc @jjyao to take a look and merge. Also we may want to support ExceptionGroups later.

The name `image_uri`, and its arguments being a plain string is IMO too specific. If later we have some more options, for example some CPU and mem limits, the name...

Is this an API break? i.e. `container.worker_path` is no longer respected

Can we make it backward compatible, you can choose either: 1. If user set a worker_path, use that. Else, use the inferred one. 2. If user set a worker_path, print...

@c21 you are the last one touched that file. Would you mind take a look? Thanks.

## Status Report I made it to a point that it can replace *all* of the existing GcsAioClient, and the `internal_kv_*` part of the GcsClient, with some incompatibilities. ## Architecture...

`python/ray/serve/tests/test_gcs_failure.py::test_controller_gcs_failure[False]` failed only because interal kv get is expected : ``` except ray.exceptions.RpcError as e: raise KVStoreError(e.rpc_code) ``` so we need to move back all TimeoutError back to RpcError (sad)...

TODOs before merging this: - [ ] https://github.com/ray-project/ray/pull/45817 Reconcile PythonGcsClient error handling (e.g. timeout vs rpc error) - [ ] https://github.com/ray-project/ray/pull/46057 Change current get_all_node_info to return `Dict[NodeID, gcs_pb2.NodeInfo]` - [...

can't do this - id.h depends on logging.h, which can't depend on id.h. Tried to forward declare but also failed.