ray icon indicating copy to clipboard operation
ray copied to clipboard

[runtime-env] automatically infer worker path when starting worker in container

Open zcin opened this issue 1 year ago • 1 comments

[runtime-env] automatically infer worker path when starting worker in container

TODO: fill in.

Signed-off-by: Cindy Zhang [email protected]


Stack created with Sapling. Best reviewed with ReviewStack.

  • -> #42304
  • #45156

zcin avatar Jan 10 '24 19:01 zcin

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

stale[bot] avatar Mar 17 '24 09:03 stale[bot]

Is this an API break? i.e. container.worker_path is no longer respected

rynewang avatar Jun 05 '24 21:06 rynewang

Is this an API break? i.e. container.worker_path is no longer respected

Yes, but it is no longer necessary.

zcin avatar Jun 06 '24 23:06 zcin

Can we make it backward compatible, you can choose either:

  1. If user set a worker_path, use that. Else, use the inferred one.
  2. If user set a worker_path, print a warning about it being deprecated and we will actually use xxx/default_worker.py.

rynewang avatar Jun 10 '24 16:06 rynewang

Can we make it backward compatible, you can choose either:

  1. If user set a worker_path, use that. Else, use the inferred one.
  2. If user set a worker_path, print a warning about it being deprecated and we will actually use xxx/default_worker.py.

I'm OK with that, I will add back support for worker_path as a deprecated option.

zcin avatar Jun 10 '24 21:06 zcin

@jjyao Could you help take a look / merge?

zcin avatar Jun 11 '24 21:06 zcin