[runtime-env] automatically infer worker path when starting worker in container
[runtime-env] automatically infer worker path when starting worker in container
TODO: fill in.
Signed-off-by: Cindy Zhang [email protected]
Stack created with Sapling. Best reviewed with ReviewStack.
- -> #42304
- #45156
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
- If you'd like to keep this open, just leave any comment, and the stale label will be removed.
Is this an API break? i.e. container.worker_path is no longer respected
Is this an API break? i.e.
container.worker_pathis no longer respected
Yes, but it is no longer necessary.
Can we make it backward compatible, you can choose either:
- If user set a worker_path, use that. Else, use the inferred one.
- If user set a worker_path, print a warning about it being deprecated and we will actually use xxx/default_worker.py.
Can we make it backward compatible, you can choose either:
- If user set a worker_path, use that. Else, use the inferred one.
- If user set a worker_path, print a warning about it being deprecated and we will actually use xxx/default_worker.py.
I'm OK with that, I will add back support for worker_path as a deprecated option.
@jjyao Could you help take a look / merge?