Rylan Collins comments

Results 5 comments of


                                            Rylan Collins

fix: guard compatibility for GetServiceDefinition requests

Hi @davydovanton. Thanks for creating this PR and sorry for the delay. If I understand the issue you're trying to fix, it looks like https://github.com/Gusto/apollo-federation-ruby/pull/45 may have already fixed it....

Editor window closes when clicking SHA link with Shadow DOM enabled

I'm experiencing this on Yosemite as well. It doesn't exactly cause Atom to crash. Instead, it looks like the current editor window crashes (or disappears) as if I closed the...

Translations prop being passed to the input control as a prop causing failure

I just published v1.0.1 which should fix all React warnings. Please try that version.

MaskedField doesn't not update child div with the new value prop despite saying it handles standard input props

@Elliot128 are you passing in a value for the `mask` prop? Without a `mask` prop, MaskedField just forwards all of the given props to the child `input`.

reinit value and buffer on mask change

@murzvo It looks like there was a compatibility issue with my tests and later versions of React. I just updated the tests. Try merging and see if that fixes things.