git-blame icon indicating copy to clipboard operation
git-blame copied to clipboard

Published 20 hours ago • verified publisher icon alexcorre

Editor window closes when clicking SHA link with Shadow DOM enabled

Open tomkadwill opened this issue 10 years ago • 14 comments

When clicking the sha link atom crashes silently, raising no errors or console output.

I am running Xubuntu 14.04

tomkadwill avatar Jan 17 '15 20:01 tomkadwill

I've just tested on OS X Yosemite and the same thing is happening there. I've tried debugging but Atom crashes without any output. Any ideas?

tomkadwill avatar Jan 18 '15 09:01 tomkadwill

:+1: I'm seeing this on Yosemite as well.

schreifels avatar Jan 21 '15 00:01 schreifels

I'm experiencing this on Yosemite as well. It doesn't exactly cause Atom to crash. Instead, it looks like the current editor window crashes (or disappears) as if I closed the window, but the process continues to run. If I pull up the dev tools in a separate window, the only error that logs is a GET error for the GitHub commit URL (404).

rylanc avatar Jan 23 '15 17:01 rylanc

same for me on OS X Yosemite

guitarman avatar Jan 26 '15 13:01 guitarman

I'll look into this as soon as I can. I'm a bit swamped with other work right now so will welcome PRs!

alexcorre avatar Jan 27 '15 19:01 alexcorre

Clicking a link shouldn't take down the whole editor so I reported this to core: atom/atom#5388

dmnd avatar Feb 04 '15 02:02 dmnd

A workaround for this bug is to disable Shadow DOM.

dmnd avatar Feb 05 '15 08:02 dmnd

Same problem here.

janraasch avatar Feb 11 '15 09:02 janraasch

@dmnd thanks for the workaround, disabling the Shadow DOM keeps things running.

FreakTheMighty avatar Feb 16 '15 18:02 FreakTheMighty

@rylanc is right. It appears like atom is trying to open the page inside the editor. Console shows

Navigated to https://github.com/tolingo/file-convert/commit/58ab44b9b1783a763dc57ffec8b65e11ad7e2d27

janraasch avatar Feb 17 '15 07:02 janraasch

BTW: atom keeps humming along in the background, refusing to start any new editor from the terminal (atom .) or the desktop file (the linux .desktop links) giving this exception:

TypeError: Cannot read property 'substr' of null
    at AtomWindow.module.exports.AtomWindow.getLoadSettings (/usr/share/atom/resources/app/src/browser/atom-window.js:132:69)
    at AtomWindow.module.exports.AtomWindow.containsPath (/usr/share/atom/resources/app/src/browser/atom-window.js:167:27)
    at AtomWindow.module.exports.AtomWindow.containsPaths (/usr/share/atom/resources/app/src/browser/atom-window.js:158:19)
    at /usr/share/atom/resources/app/src/browser/atom-application.js:521:61
    at /usr/share/atom/resources/app/node_modules/underscore-plus/node_modules/underscore/underscore.js:159:21
    at Array.some (native)
    at _.some._.any (/usr/share/atom/resources/app/node_modules/underscore-plus/node_modules/underscore/underscore.js:208:59)
    at Object._.find._.detect (/usr/share/atom/resources/app/node_modules/underscore-plus/node_modules/underscore/underscore.js:158:5)
    at AtomApplication.module.exports.AtomApplication.windowForPaths (/usr/share/atom/resources/app/src/browser/atom-application.js:520:16)
    at AtomApplication.module.exports.AtomApplication.openPaths (/usr/share/atom/resources/app/src/browser/atom-application.js:592:31)

Hope that helps. Killing the atom process is the only way to get it to work again.

despairblue avatar Mar 10 '15 13:03 despairblue

I'm seeing this on Yosemite, too.

xdumaine avatar Apr 24 '15 11:04 xdumaine

I've added a pull request that fixes displaying of git blame in the gutter and opening of remote revision diffs. #98

If you want to try it out:

cd ~/.atom/packages
git clone https://github.com/filipminev/git-blame.git git-blame-tmp
cd git-blame-tmp
apm install .

filipminev avatar Jun 30 '15 12:06 filipminev

@filipminev you're the best

xdumaine avatar Jun 30 '15 15:06 xdumaine