Ryan Mitchell

❤️

@jasonvarga I've gone ahead and added `whereRole`, `whereGroup` etc to the query builder to be used for role and group querying. It builds on the previous work so still uses...

Yes this assumes you define a roles and groups relation on your user model. That would need documented.

Hmm my memory is hazy on this and I’m not at my machine to dive into the code. I’ll take a fresh look once I’m back.

Ok @edalzell @jasonvarga I've updated this to not require a relation to be set. You'll see in the eloquent UserQueryBuilder it now checks if a relation exists, and if not...

@jasonvarga I've updated this to target 4.x now but all the tests are now failing locally. It's super strange, and I can't track the change thats caused it. It feels...

Thanks for the help @jasonvarga - I wouldn't have noticed that. Everything seems in order from my side now - I also double checked and its creating the same yaml...


@icemancast im guessing you added ‘true’ to the config values rather than the name of the table.

@faustbrian I've merged it in. There are some test failures now but they are related to forms untouched by this PR so I think its a Github failure.