Ryan Mitchell

Results 264 comments of Ryan Mitchell

This should now be complete with everything needed for the Eloquent all models PR

I've been doing a bit of work on the eloquent driver over this week and it strikes me that this class might be better being bundled as part of that,...

Yeah I remembered that after I asked. Friday brain

Thanks for the suggestion. I've pushed an update with that, which allows toSql, dd and count to be removed. However, when/unless/tap need to stay as otherwise the subquery gets an...

No problem - I've updated that method to be called `getDirtyArray()` (please come up with something better), and put some of the data logic in there. Also separated out a...

Yep I can see the syncOriginal function - see how I've updated to look for `getDirtyArray` if it exists (seemed like the best approach). However, I've no idea where in...

Thank you! Thats updated now - let me know what you think.

Not sure why tests are failing on this (and they seem unrelated to the changes made). They are all passing for me locally.

@jasonvarga Struggling a bit with the tests on this one. On the two asset failures, do I just update the tests to expect the .meta files? Or do I handle...

I've got all tests passing locally now, but I cant get them working here in GitHub actions. If you can see why that would be really helpful.