Ryan Mitchell
Ryan Mitchell
@jasonvarga would be great to get this merged as ordering isn't working in the CP at the moment.
Yeah I was trying to avoid adding a column but I guess in hindsight it’s just making things more complicated. I’ll refactor it to use a nullable order column
Order is a reserved word in some db engines. I’ve always avoided using it as a result. Yeah the migrations annoyed me too - I don’t like the approach of...
Ok I’ll change it over later on. Yeah I should have really pushed back on the migrations, I knew it wasn’t the right approach - sorry about that. do we...
Sorry that ive left you with a mess to clean up!
We probably need to bring some of this method over to the Eloquent Asset class: https://github.com/statamic/cms/blob/c09bbd0f5eb5eec3615e81532da0e08b8aea0e9b/src/Assets/Asset.php#L655-L680 Or at least cache the old metaPath, call the parent method, then update the...
Should do.
Hmm that feels like an unnecessary db query - keen to avoid that. Does[ this change help](https://github.com/statamic/eloquent-driver/pull/71/commits/e7690c8f76cf8dc6843f8a43fb27322f3cf40714)?
Im not sure about that - its in the file based version so it must be there for a reason. I cant recreate your issues so it would be helpful...
I've opened a PR here: https://github.com/statamic/eloquent-driver/pull/64