Ryan Merolle

[Feature]: Add assigned_object models in GraphQL API similar to the REST API

2

### NetBox version v3.2.6 ### Feature type Add a function ### Proposed functionality NetBox core graphql package does not support walking assigned_object_type/assigned_object_id approach to relations. ### Use case It would...

Add model tests

3

# Pull Request ## Related Issue Closes #47 Closes #133 ## New Behavior - Adds tests to models. - Addresses a bug found in the AccessList model discovered while adding...

Issue 67

2

# Pull Request ## Related Issue Closes #67 ## New Behavior ... ## Contrast to Current Behavior ... ## Discussion: Benefits and Drawbacks ... ## Changes to the Documentation ......

### Proposed Changes Test each form included in the plugin Examples: [NetBox SecretStore Plugin](https://github.com/DanSheps/netbox-secretstore/tree/develop/netbox_secretstore/tests) [NetBox BGP Plugin](https://github.com/k01ek/netbox-bgp/tree/main/netbox_bgp/tests) [NetBox Tunnels Plugin](https://github.com/jdrew82/netbox-tunnels-plugin/tree/master/tests) [NetBox Tenancy Model](https://github.com/netbox-community/netbox/tree/develop/netbox/tenancy/tests) ### Justification Testing should be built into...

### Proposed Changes Test each api included in the plugin Examples: [NetBox SecretStore Plugin](https://github.com/DanSheps/netbox-secretstore/tree/develop/netbox_secretstore/tests) [NetBox BGP Plugin](https://github.com/k01ek/netbox-bgp/tree/main/netbox_bgp/tests) [NetBox Tunnels Plugin](https://github.com/jdrew82/netbox-tunnels-plugin/tree/master/tests) [NetBox Tenancy Model](https://github.com/netbox-community/netbox/tree/develop/netbox/tenancy/tests) ### Justification Testing should be built into...

### Proposed Changes Test each model included in the plugin Examples: - [NetBox SecretStore Plugin](https://github.com/DanSheps/netbox-secretstore/tree/develop/netbox_secretstore/tests) - [NetBox BGP Plugin](https://github.com/k01ek/netbox-bgp/tree/main/netbox_bgp/tests) - [NetBox Tunnels Plugin](https://github.com/jdrew82/netbox-tunnels-plugin/tree/master/tests) - [NetBox Tenancy Model](https://github.com/netbox-community/netbox/tree/develop/netbox/tenancy/tests) ### Justification Testing...

[Housekeeping]: Address duplicate code as much as possible

2

### Proposed Changes Eliminate code duplication specifically in `netbox_acls/api/serializers.py` ```bash Clone found (python): - /github/workspace/netbox_acls/api/serializers.py [159:15 - 173:12] (14 lines, 93 tokens) /github/workspace/netbox_acls/api/serializers.py [80:13 - 94:12] Clone found (python): -...

### NetBox version v3.4.3 ### Feature type Add a function ### Proposed functionality Apply interface list view similar to devices but on the acl page ### Use case It would...

Ideal for modeling most platforms, but not for platforms like NX-OS. I am not currently leveraging for NX-OS, so I do not care as much. I worry about scope creep,...