Issue 67

[ryanmerolle]

Pull Request

Related Issue

Closes #67

New Behavior

...

Contrast to Current Behavior

...

Discussion: Benefits and Drawbacks

...

Changes to the Documentation

...

Proposed Release Note Entry

...

Double Check

• [x] I have explained my PR according to the information in the comments or in a linked issue.
• [x] My PR targets the dev branch.

[sourcery-ai[bot]]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 9.48%.

Quality metrics	Before	After	Change
Complexity	4.86 ⭐	1.40 ⭐	-3.46 👍
Method Length	84.17 🙂	71.22 🙂	-12.95 👍
Working memory	11.04 😞	9.82 🙂	-1.22 👍
Quality	62.58% 🙂	72.06% 🙂	9.48% 👍

Other metrics	Before	After	Change
Lines	1777	1944	167

Changed files	Quality Before	Quality After	Quality Change
setup.py	90.09% ⭐	89.94% ⭐	-0.15% 👎
netbox_acls/tables.py	40.46% 😞	40.40% 😞	-0.06% 👎
netbox_acls/views.py	82.12% ⭐	82.03% ⭐	-0.09% 👎
netbox_acls/api/serializers.py	67.28% 🙂	80.24% ⭐	12.96% 👍
netbox_acls/forms/filtersets.py	34.01% 😞	34.36% 😞	0.35% 👍
netbox_acls/forms/models.py	50.75% 🙂	76.40% ⭐	25.65% 👍
netbox_acls/migrations/0002_alter_accesslist_options_and_more.py	61.79% 🙂	61.79% 🙂	0.00%
netbox_acls/migrations/0003_netbox_acls.py	75.10% ⭐	75.10% ⭐	0.00%
netbox_acls/models/access_list_rules.py	97.98% ⭐	97.87% ⭐	-0.11% 👎
netbox_acls/models/access_lists.py	94.10% ⭐	94.02% ⭐	-0.08% 👎
netbox_acls/tests/test_api.py	71.73% 🙂	69.88% 🙂	-1.85% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
netbox_acls/tests/test_api.py	setUpTestData	0 ⭐	296 ⛔	7 🙂	59.96% 🙂	Try splitting into smaller methods
netbox_acls/api/serializers.py	AccessListSerializer.validate	3 ⭐	65 🙂	10 😞	71.13% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
20 Code Smells

No Coverage information
0.0% Duplication