Gyeongjae Choi

Results 674 comments of Gyeongjae Choi

Thanks for the report and proposal, @CNSeniorious000! I am +1 for enhancing the Console module as you suggest. The reason we have a console module is to implement [a simple...

Could you elaborate, please? Since everything in Pyodide runs under the browser, those proxy settings need to be handled by the browser, not by Pyodide.

Well, it still runs in Node.js anyway, and I think the Node.js runtime should handle those proxy settings.

Seems like node.js does not respect system proxy, and there is no proxy support in native fetch in Node.js >= 18. - https://github.com/nodejs/node/issues/42814

> Anyway, it seems there's a general workaround using proxy agents https://stackoverflow.com/a/60162799 but short of overriding the fetch function (which I'm not sure is feasible) unless pyodide explicitly allows passive...

Thanks @joemarshall. As I commented in #4892, I would prefer supporting [`data_files`](https://setuptools.pypa.io/en/latest/deprecated/distutils/setupscript.html#installing-additional-files) instead of having a package to install the file itself. Also, could you upload the package to PyPI...

> I think the only advantage to having a separate package to this (as opposed to it being in data_files of arrow) is that it is possible other packages will...

I think supporting `data_files` (https://github.com/pyodide/micropip/issues/18) can do the trick instead of adding a separate package type. While `data_files` support in setuptools is deprecated, AFAIK there isn't a standard for installing...

Thanks for the suggestion @agriyakhetarpal! I still think the easiest thing to do is to try hard to convince the anaconda folks to put adding CORS headers on their TODO...

> I don't know much about JS/cloudflare, and stugled to do even do a small prototype, so if you know what you are doing we've better to adapt your code...