Gyeongjae Choi

icon indicating a website link https://ryanking13.github.io icon indicating an email [email protected]

icon company MOLOCO icon location Seoul, South Korea icon location Software Engineer | Member of @pyodide core dev

Results 674 comments of Gyeongjae Choi

FIX Fix node global scope again

Thanks! It seems like you pushed to the main branch already. So I guess we can close this?

`build-packages-no-numpy-dependents` Tests fail with "`ModuleNotFoundError. No module named ...`"

Thanks for opening the issue! It would definitely be nice to show some better traceback when unpickling fails. For now, you can directly use the selenium fixture in your tests...

Enable setting of selenium runner capabilities

Thanks for opening the issue, @joemarshall! I agree that we need some way to provide custom options for browsers. ``` I can see we have access to Options, so I...

TST: can't pickle pyodide.InternalError

The CI succeed in the main branch after merging #80, and we don't run CI against 0.23.0, so I guess it is flaky becuase of some randomness in hypothesis? I...

Add safari runner for playwright

It seems like the safari runner hangs very often...

wasm_backend vs. html5_canvas_backend

You can check the following blog post and Gsoc project proposal. - https://blog.pyodide.org/posts/canvas-renderer-matplotlib-in-pyodide/ - https://summerofcode.withgoogle.com/archive/2019/projects/4683094261497856 cc: @madhur-tandon

"module://matplotlib_pyodide.wasm_backend" should auto clear the old pictures instead of generate new pictures

Thanks for opening the issue. There is currently no maintainer actively managing matplotlib-pyodide, so it would be great if you could contribute to the issues you see.

plotting fails with `document.pyodideMplTarget` set

> Now, plotting works but the target div is not reused and I still get the default append behavior. html attached. The target div is used, but what happens is...

Replace maxdict with lru_cache

I think we can merge and release? @hoodmane

AttributeError: 'TimerWasm' object has no attribute '_timer'

Thanks for the report! It seems like there was a `_timer` attribute in `TimerBase` object in old matplotlib versions but it has been removed. So the `TimerWasm` object would need...