Gyeongjae Choi comments

Results 674 comments of


                                            Gyeongjae Choi

Unknown typed array type 'BigInt64Array' when using transformers v3 with Xenova/Phi-3-mini-4k-instruct

Thanks for the report. I guess we need to add `BigInt64Array` here. https://github.com/pyodide/pyodide/blob/eb1d208638064bafa03e298cfbe358a6b5cc2832/src/core/jslib.c#L410-L424

Mac builds: Pyodide Venv: `pytest` breaks when `python -m pytest` does not

> I think this may be in the category of too complicated to be worth our limited development time, unless someone wants to work on it. We can tell people...

pyodbc package build error

It would be nice if you could share us a full build log.

STATUS_BREAKPOINT on Microsoft Edge

Hmm, I cannot reproduce it in my Windows 10 + Microsoft Edge 124.0.2478.105. If someone can reproduce it it would be helpful for us to debug.

Add test files unvendoring functionality

Thanks for the proposal @agriyakhetarpal! I made a similar issue in the pyodide-lock repository: https://github.com/pyodide/pyodide-lock/issues/30, because I thought the test unvendoring feature was related to the lockfile. But if you...

Add test files unvendoring functionality

This issue is also worth reading: https://github.com/pyodide/pyodide/issues/3092. Of course, this is a separate discussion from moving the test unvendoring feature, but it would be helpful to be able to generalize...

Add test files unvendoring functionality

Yeah, I also like the third option. Thanks for listing up the possible interfaces.

Implement ability to specify a custom fetcher to `pyfetch`.

I guess this is for internal use in CloudFlare? I am not opposed to this PR, but it would be nice to provide more context about the usage so we...

Implement ability to specify a custom fetcher to `pyfetch`.

I see. Makes sense. I am fine with this change, then, but I'll let @hoodmane approve as he might have more ideas. Also, could you please update the testcase and...