Ryan Baxter

Results 639 comments of Ryan Baxter

Are we talking about monitoring just in an actuator sense?

I am thinking more about this now, and maybe this kind of relates to what I am suggesting in #286. Maybe it is up to the extending module to make...

For example for development locally I might target Minikube or Docker Desktop, but for staging/production I might target GKE

Yeah I guess so. The term profile is overloaded, but essentially I want to have configuration for different k8s deployments I might be deploying my app to.

@iocanel I think that is a nice start but not really what I am envisioning. I would like these "listeners" to live outside of Dekorate in other jars. Dekorate would...

Quoting @iocanel from #288 > Currently, using the java.util.ServiceLoader anyone can provide a custom BeanListener which can dekorate the manifests as sees fit. We can extend this concept to classes...

I dont have any issue :) I just wanted some other eyes on the subject that is all. I think the `ServiceLoader` is a fine place to start.

Shouldn't the `@ConfigurationProperties` class above have an `@RefreshScope` annotation on it to make this work?

I still dont see why adding `@RefreshScope` to `DataSourceDynamicProperties` wouldnt do what you need

The key term is "HTTP errors". Not having any instances available doesnt seem like an HTTP error to me.