Ryan Baxter
Ryan Baxter
Looks like you have a potential fix in your fork, would you like to submit that as a PR to the project?
Fixed via 009ee54
Sorry @snicoll I didnt check the issues the PR claimed it fixed, thanks for reopening.
I approved the checks, you have checkstyle errors
I dont see how that would be possible, that would imply that there are checkstyle errors in the code and if that was the case our builds would be failing...
Would you be interested in submitting a PR based on that patch?
I noticed that the tutorial example creates a jar with all the class files for all of the dependencies, why is that necessary?
@brendandburns when you say "java app" are you referring to the metaparticle code? The metaparticle jars should be on the classpath, why do the class files need to be packaged...
So could we create an image that contains the metaparticle code within it so its not necessary for each app to do this?
@kubamarchwicki I think option 3 is the approach to take. There is no reactive implementation for Spring Retry either so we just implemented the non-reactive apis.