Ryan Baxter

Results 639 comments of Ryan Baxter

Can you provide a [complete, minimal, verifiable sample](https://stackoverflow.com/help/mcve) that reproduces the problem? It should be available as a GitHub (or similar) project or attached to this issue as a zip...

@Ferioney would you be interested in adding support?

Could you not just use those annotations directly?

If you are just going to use the Resilience4J annotations why would you include the spring cloud circuitbreaker jars?

Yeah not currently we dont have annotations. The topic has come up before, I thought there was already an issue open for this but I can't seem to find it,...

If we don't call the `create` method when `normal` is called I think that would solve the problem no?

https://github.com/Ferioney/spring-cloud-circuitbreaker/blob/defect_addCircuitBreakerCustomizer/spring-cloud-circuitbreaker-resilience4j/src/test/java/org/springframework/cloud/circuitbreaker/resilience4j/Resilience4JCircuitBreakerIntegrationTest.java#L198

@Ferioney @limng06 can you confirm if this is still a problem with the latest release Spring Cloud 2021.0.0?

I think retry can be implemented pretty easily outside of Spring Cloud CircuitBreaker, do you have a good reason as to why it should be part of the API?