Robert Jackson
Robert Jackson
@CvX - have any time to revise?
Ya, in retrospect I agree. I can do a patch release to rerelease 0.5.7 in a 0.5.9 release, then release a "breaking change" release (likely 1.0.0 since I don't see...
Eeck, sorry @camerondubas, will try to review tomorrow :weary:
I don't understand the question, can you explain what you are trying to do?
No, it was removed in https://github.com/tildeio/simple-html-tokenizer/commit/01479fe883cee3ead68079ec0f576cdcfc1e96fd
@estshy - Can you attempt to submit a failing test case for this? It would almost certainly make fixing much easier... @bantic - Sorry to pester you here, but I...
Yep. Fix it.
Yes, this seems good to me. I'm ok with a shorter deprecation period also (through the next LTS release)...
AFAICT this is just the way the promise spec works. I don’t think we should diverge from the spec here...
This fix looks good conceptually, but we need to fixup the tests and add a specific test for the scenario described in https://github.com/emberjs/ember.js/issues/18577