Robert Jackson

Results 989 comments of Robert Jackson

> I can only replicate this actually when running tests. Calling visit('/') before visiting the route that has the query param transition does seem to fix it. So this error...

I'd have to look deeper to be 100% sure, but I'm fairly sure we don't do anything special to keep `loc` updated after a mutation. It's probably possible to do,...

This seems (unfortunately) like designed behavior. The params are held in a single level POJO where the keys are the dynamic segment name. There really isn't anything we can do...

I think you could probably use `volta install ...` instead as a work around. Would you mind trying that?

Ya, makes sense. I'm not sure off the top of my head why that didn't work. It's probably something related to `$PATH` ordering...

Would you mind being a bit more descriptive here? When you say: > default query params and non-included query params are not accounted for properly And: > when using hash...

For example, it is my understanding that the router service _should never_ be eliding default query param values and therefore I would not expect `isActive` to return `true` when given...

I think it should generally be considered a bug if service injections fail. The issue in this case is that the router service itself gets router:main injected into it. What...

Sorry I missed this at the time @chriskrycho. I think it should be fairly straightforward (e.g. "not too hard") to remove the auto-injection, and only look up the router service...