router.js icon indicating copy to clipboard operation
router.js copied to clipboard

fix: qp-only transition during initial transition

Open buschtoens opened this issue 4 years ago • 4 comments

Seems to fix https://github.com/emberjs/ember.js/issues/18577.

image

buschtoens avatar Oct 29 '20 17:10 buschtoens

Please see my comment here: https://github.com/emberjs/ember.js/issues/18577#issuecomment-719001736 Not sure if this is another bug or if this fix does not address the root cause.

jelhan avatar Oct 29 '20 20:10 jelhan

This fix looks good conceptually, but we need to fixup the tests and add a specific test for the scenario described in https://github.com/emberjs/ember.js/issues/18577

rwjblue avatar Nov 06 '20 01:11 rwjblue

@buschtoens status?

wagenet avatar Feb 09 '22 15:02 wagenet

@buschtoens @rwjblue Is this solution still good? if so is there anything i can do to help get this merged? Happy to write the test for it if i can be pushed in the correct general direction, im not overly familiar with this code.

Mikek2252 avatar Aug 23 '23 16:08 Mikek2252