Ryan VanderMeulen

Results 32 comments of Ryan VanderMeulen

A couple more instances: ``` ots/src/stat.cc(264,34): warning: comparison of integers of different signs: 'long' and 'uint32_t' (aka 'unsigned int') [-Wsign-compare] if (out->Tell() - tableStart != this->designAxesOffset) { ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~...

@skhamis Is this ready to land?

Sorry, I don't think I'm in a position to meaningfully review this.

Note that Gradle 7.5.1 & Plugin 7.2.2 are the latest versions now.

Does git have a way of ignoring certain commits for blame purposes? That's we done on the Mercurial side of things when landing mass reformatting changes like this.

Looks like the gradle-dependencies job is hitting real failures. > warn: removing resource mozilla.components.feature.accounts:string/mozac_browser_errorpages_page_go_back without required default value. > warn: removing resource mozilla.components.feature.accounts:string/mozac_browser_errorpages_page_title without required default value.

@Mugurell This is busted due to https://github.com/mozilla-mobile/android-components/pull/12560. Can you please address the breaking change here as well? Thanks!

This doesn't appear to be working. I'm trying to bisect bug 1402013. I gave it a range of 2014-09-28 to 2017-09-28, but all the builds it tried to test were...

I'm still seeing this with the latest Nightly build on my device. @MatthewTighe