application-services
application-services copied to clipboard
Allow M1 building & testing via arm64 JDK
- [x] Can run tests in a-s using arm64 JDK
- [x] Can run tests in a-c (using local published flow) using arm64 JDK
- [x] Can run tests in fenix (using local published flow) using arm64 JDK
Pull Request checklist
- [ ] Quality: This PR builds and tests run cleanly
- Note:
- For changes that need extra cross-platform testing, consider adding
[ci full]
to the PR title. - If this pull request includes a breaking change, consider cutting a new release after merging.
- For changes that need extra cross-platform testing, consider adding
- Note:
- [ ] Tests: This PR includes thorough tests or an explanation of why it does not
- [ ] Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
- Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
- [ ] Dependencies: This PR follows our dependency management guidelines
- Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.
Codecov Report
Merging #4898 (43bd433) into main (8f6e8fa) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #4898 +/- ##
=======================================
Coverage 38.46% 38.46%
=======================================
Files 166 166
Lines 12353 12353
=======================================
Hits 4751 4751
Misses 7602 7602
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8f6e8fa...43bd433. Read the comment docs.
@skhamis Is this ready to land?
@skhamis Is this ready to land?
Hey Ryan, I haven't been able to run the full test just yet (I need to make sure arm64 jdk compiles & tests all the way up to fenix) but I should be able to soon!
Sorry, I don't think I'm in a position to meaningfully review this.