Rusty Russell

Results 308 comments of Rusty Russell

I'm going to leave this PR open. Though it's mitigated for 0.12 in #5342 I know that CPU usage can be further significantly reduced. @whitslack is most likely to see...

OTOH, this is not a regression since previous versions; it has long been this way.

I don't think this should go in now, at it risks breaking every other platform that now needs to figure out how to get lowdown, update their docs etc.

> ![image](https://user-images.githubusercontent.com/93665/180904757-354dd6b1-31d8-4996-97d1-3ec265bd0bb7.png) > > Here's the `diff -u` of particularly the `min_final_cltv_expiry` example from above. OK, I've fixed this now.

Rebased, and formatting fix. The extra blank line before sub-indents is a bit jarring, but seems the best we can do for now? (See man -l doc/lightning-decode.7)

> Just a word of caution: `lowdown` is only available in Ubuntu LTS starting from 22.04. So we might need to also add pointers to install it on older versions...

It's already in the "getmanifest" call: ``` json_add_bool(req->stream, "allow-deprecated-apis", deprecated_apis); ``` Which is often where it's needed (you might not want to register deprecated apis at all).

Already implemented for 0.12: https://github.com/ElementsProject/lightning/pull/5281/commits/6ed5f3153b19889391f7df4e8edef0d3ac2d3500

Hmm, maybe we allow filename at the beginning of 'log-level', like: ``` log-file=/var/log/lightningd/info.log log-level=/var/log/lightningd/info.log:info ``` Awkward, but allows `:` in log filenames.

Hmm can you add a `Changelog-Fixed: bcli: don't expose bitcoin RPC password on commandline` to the commit message, so we make sure it gets noted in the CHANGELOG.md for next...