Rusty Russell comments

Results 308 comments of


                                            Rusty Russell

lightningd: fix segfault when parse_filter fails

And here's the blog post I made about it, with video! https://rusty.ozlabs.org/2025/12/12/CLN-Neatening-A-Bugfix-PR.html

Peer storage enhancements

Because this needs review and it's been delayed, I'm going to move this back to the next milestone. Once rc1 is out I will try to find time for a...

xpay: Allow "includefees" option to deduct fees from total.

I think you end up approximating (assume max paid as fees), then increasing each payment slightly, then if all else fails, spending the last few sats on extra fees?

Changed: offers: offers that include offer_paths now omit the offer_issuer_id and sign with the last used blinded path alias' key by default

This invoice is invalid: let's break it down by type, length, value (hex) - 00 10 fc84667539e41bd6564fbbdb87d3375e - 02 20 43497fd7f826957108f4a30fd9cec3aeba79972084e90ead01ea330900000000 - 0a 07 6e657774657374 - 10 ee 03e5c9e190e93af5f757e533ad12ca2da9daef99f337a7af0320e70feae9a7890003b224fa465507bf714641c64a1018ccc05bbcda60d3aa15212e577dfd8e0fb9ea020202a9628f99168a0b09c8ddc71bd9191e31f871075cd8854968dbb72d47c3912100338139ad02276007ea918fa7208765a306c200c7af814c0284deca7ced13b36863c84d03393572ef44d44d78cce9b0bf58a6ff8c02c1a165fe61b4fc6c2097bee34d538fbc84902df62e0bf8eac81495971d491b3600324a46184f1c237f594b5cd4797f794c0b3f2267b8ff51e55376aa7053a5b708ad7c7056dd0b537494580af8f872b9972cebba -...

Proper consensus forming process for choosing release names

FWIW, we generally ask the most significant contributor (who hasn't already) to name the new release. The previous namers also get CC'd for advice and assistance.

`pre-commit` hooks demo

It's always good to have an opinionated list. The downside is, we might all disagree with that list! In particular, the conventionalcommits.org is crap. I hate "chore:" as a prefix....

fuzz-tests: Add a test for `fundee_channel()`

Rebased. The inter-daemon comms changed, so the corpora will have to be rebuilt I think?

macos apple silicon: We need a libsodium >= 1.0.4

Please try compiling this with "-Wall -Wundef -Wmissing-prototypes -Wmissing-declarations -Wstrict-prototypes -Wold-style-definition -Werror"? ``` #include #include #include int main(void) { crypto_secretstream_xchacha20poly1305_state crypto_state; unsigned char header[crypto_secretstream_xchacha20poly1305_HEADERBYTES]; unsigned char key[crypto_secretstream_xchacha20poly1305_KEYBYTES]; crypto_secretstream_xchacha20poly1305_keygen(key); crypto_secretstream_xchacha20poly1305_init_push(&crypto_state, header,...