Rusty Russell

Note that some commands are either experimental or internal use only. We haven't documented this well in the past, so they get baked in: we should consider this in future.

We should also move this list of supported commands to the schema, where documentation can access it.

We simply check that it's valid UTF-8 (it's part of our parsing code): ``` $ ./devtools/bolt12-cli decode lno1qcplllhapqpq86q2q4qkc6trv5tzzq6muh550qsfva9fdes0ruph7ctk2s8aqq06r4jxj3msc448wzwy9s bolt12-cli: Bad offer: invalid offer data ``` If it's an unknown currency...

Yes, the ping command is unreliable. We are only supposed to ever send one ping at a time, but we also send them internally, so the manual ping can get...

Actually, it does look like they should piggyback on our keep alive pings? I'll see if I can reproduce this with aggressive testing...

I cannot reproduce this, at least in master. You *will* get a ping failure, in that it will report "'error': {'code': -1, 'message': 'Ping already pending'}}" if you happen to...

OK, so getroutes() is different than getroute(). I should document this properly. It's optimized towards onion creation, i.e. these are what you would put in the intermediary onions. So, it's...

Nice! Might take a while to reach feature parity, I've asked @ShahanaFarooqui to review...

This is the bitcoind decode (after using lightningd to change to PSBT v0) for this one: ``` $ bitcoin-cli -regtest decodepsbt cHNidP8BAHsCAAAAApW0PeqOlpqz1hIp1r4+KwriopJpqLSNFIOiQTyVKB5mDAAAAAABAAAAezYB4+Elfc4jrZEpxmJGQ+JB+ZY+Nyp59175wI4WyTgAAAAAAP3///8B8gVLAAAAAAAWABRysv9fpmoSqJ8TwI1cAYrWjMFCXNZ4JwAAAQD9aQMCAAAAAAEBtHkxKg5GGVQGPoYTq6Pz0gqE3CrOcIz7qJx91hJ4zQcBAAAAAHT094AOSgEAAAAAAAAiACCAdnGSg9tgZH64wvG9ijxrvJTXgzF3QlyHT74r4ax9W0oBAAAAAAAAIgAg9ukbv8J3lesNxsNka6Nyv5zEJAmkKaR34GbK8t29qvujawAAAAAAACIAIEBOAmbooc1LtdUTQ9lFiuHmJ4iAwJrkM18dBM+3LozXOXQAAAAAAAAiACC+//uiUvyN7BGvM1PFu5LQlXL6Kj6v9xAMYzdIxGjrejB1AAAAAAAAIgAgGIjbfQHXOomX8uTbGV7eC1Le80rGvhKlKbHQdN7gZMJQigAAAAAAACIAIL7/+6JS/I3sEa8zU8W7ktCVcvoqPq/3EAxjN0jEaOt6EKQAAAAAAAAiACBCgxtgJbDZ0m1z6PqiyGberLZNr8o7k1bEpZjBXqryehnAAAAAAAAAIgAgvv/7olL8jewRrzNTxbuS0JVy+io+r/cQDGM3SMRo63px6AAAAAAAACIAIL7/+6JS/I3sEa8zU8W7ktCVcvoqPq/3EAxjN0jEaOt6nxQBAAAAAAAiACC+//uiUvyN7BGvM1PFu5LQlXL6Kj6v9xAMYzdIxGjrevBVAQAAAAAAIgAgvv/7olL8jewRrzNTxbuS0JVy+io+r/cQDGM3SMRo63o+KQIAAAAAACIAIL7/+6JS/I3sEa8zU8W7ktCVcvoqPq/3EAxjN0jEaOt6mmFSAAAAAAAiACD/KpicrvGAxlIWsN+P6iCfiBI/M+amT/rRX8VoW3RV2BefmgUAAAAAIgAgmNc09A2SQTp9N81JYnvsgxlhxOKAKIUke/nP/Kt/dIUEAEcwRAIgD9PsvtsdtYcfsJC0tco25N6EqchznxWu7kteIeC7gmsCIEBrpMAJ2ga0gSzpgVY+iFfNJ7iFAeiZaKBKh+2DeXnXAUcwRAIgbVfTgHuXIwqt/OnkoDr9ZtCM5caL6l+k3gCzQHJUh0ICICIrf4wBOJ9UWCTEO6xE9K7h7bDLRK0zOqJpzSrEJGY3AUdSIQJVITkBOokgRNJUyRsnfA+zqSTsLOpUaTetHLNPMrQKICEDJrcWhu5TQCEyv3yAhWkzfaeKjW/ZtvwWcXrK2uiLqx1Srpw38yABASuaYVIAAAAAACIAIP8qmJyu8YDGUhaw34/qIJ+IEj8z5qZP+tFfxWhbdFXYAAEBK0oBAAAAAAAAIgAggHZxkoPbYGR+uMLxvYo8a7yU14Mxd0Jch0++K+GsfVsBCHICRzBEAiBhDVPPDEtGbC0Qw3NFH3cp2U5bPiA/KzzXpVQm0rtWEQIgPLeUcN8yhGxX0E1qyb26JyXlT1SANd3KwZq2w3felhIBKCECVSE5ATqJIETSVMkbJ3wPs6kk7CzqVGk3rRyzTzK0CiCsc2RgsmgAAA== { "tx": { "txid": "2ece015791069d159de1476e8b24fa11e308948d66e4e363a36924064ed3a9b5", "hash": "2ece015791069d159de1476e8b24fa11e308948d66e4e363a36924064ed3a9b5", "version":...

OK. Looking at the testnet one. We have two inputs: second is the anchor, which is finalized fine, and first is a to-remote output from a previous unilateral close, which...