Rusty Russell
Rusty Russell
Changed milestone to next point release, since this fixes a nasty issue.
This is buggy, hence the CI failures. "2024-09-20T03:41:23.4480770Z lightningd-2 2024-09-20T03:18:40.405Z UNUSUAL 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-chan#1: Not dropping our unilateral close onchain since we already saw theirs confirm." But l2 is the one which...
OK, I think the premise here is wrong. We should consider sending anchorspends after broadcast, and we do, if we consider the feerate insufficient. We don't if we've seen the...
OK, I've solved this a different (more intrusive way). Christian already changed the code so we don't send our own unilateral close tx when we have already seen a spend...
Plugins have 60 seconds to get from us sending getmanfest, to them replying to init. This should be long enough, but perhaps in the case where a lot is happening,...
Note, this is not a crash, just scary logging! I'll see if I can track it down, though!
This also implies that we are somehow not notifying gossipd when channels are force closed. These are all force closes of our own channels. These messages are somewhat harmless, but...
This kind of makes sense for "check" to do this, and return optional extra data? At the moment check doesn't return anything useful in success, but we could enhance that?
Wait 100 blocks, so it's fully settled. We don't know for sure that the channel will not get double-spent. We *could* relax this, I guess?