Russell Haering

Thanks for tackling this refactor, and sorry for taking so (very, very) long to review it. I'm generally positive on giving callers more flexibility to decide how to handle (or...

Thanks so much for the kind feedback, I'm glad to hear this solved a problem for you! I don't by any means think we've achieved total compatibility with every SAML...

Good question (and probably something that should be better documented). SAML supports signing of AuthnRequests, but support for this among IdPs is pretty variable and I'm not aware of a...

Sorry for slow follow-up. I'm not too familiar with Artifact Binding, but if you're willing to take a stab at it I'll absolute work with you to get it merged.

I'm flexible. I started with etree because it seemed like the best way to make XML signatures work, but encoding/xml does seem easier for Unmarshaling in general. As long as...

I think we should favor simple interfaces, with the goal that it should be hard to use the library incorrectly. My only concern is making sure that in the future...

Good find, you uncovered some old code that has an actual bug in it. That `CanonicalizationMethod` _has_ a namespace declared and we should have been respecting it. Can you test...

I'm open to that, I don't think it would break much. Is the goal just to reduce external dependencies?

@tjgq if you're interested I can set you up a GH repository to reproduce this pretty easily.

Merged #89 which superseded this, and just cut v0.9.1 of `gosaml2` pulling in the change. Appreciate your work on this and the (extreme) patience in waiting for it to be...