rugk

Results 1590 comments of rugk

Uhm sorry for the late review, forgot to click to submit the review.

@lazy-sunshine Are you still interested in completing this? If not, that's no problem, just add a notice, so I know what the current status of this PR is.

@lazy-sunshine Are you still interested in completing this? If not, that's no problem, just add a notice, so I know what the current status of this PR is.

Note that as of Firefox 60 the photon design has not really been applied to the elements on the options page or so… So maybe be wait or use the...

Uuuuh… wait… I cannot read the doc. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/user_interface/Browser_styles says the class `browser-style` still needs to be applied to some elements to work… ![image](https://user-images.githubusercontent.com/11966684/39678086-653dbf7c-5186-11e8-813c-0cbaeef4c6ce.png) So this is way easier than I...

It may still require some tweaking so you cannot just stupidly apply the class. E.g. this one looks crazy when applied to my select element: ![image](https://user-images.githubusercontent.com/11966684/39678097-96589bae-5186-11e8-85aa-edfc1901d9d9.png) And it seems to...

So actually the issues I saw are Firefox issues. In the PR https://github.com/rugk/offline-qr-code/pull/97 I've listed these bug reports. At least the accessibility issue with the not focusable elements makes this...

> from Q to H in common.js locally Did you notice there is actually a setting for it? So you do not need to adjust the JS for that.… :smile:

It actually should not, or… to put in in another way: This issue here is about something else. Don't know what bug you experienced with the Canvas option.

IMHO… > What use cases could be destroyed when we remove it? * As a user, I might want to save my QR code in a fixed size. * As...