Introduce smart QR code size handling and remove user options?

[rugk]

Problems

• too big for overflow menu https://github.com/rugk/offline-qr-code/issues/35
• sizing on small Android screens https://github.com/rugk/offline-qr-code/issues/151
• when settings would be synced for Firefox for Android, size settings from the desktop could create problems…
• the whole mechanism does not take the input size into account and thus generates hardly scannable QR codes for big inputs, see https://github.com/rugk/offline-qr-code/issues/90

Solution

@bfred-it suggested in https://github.com/rugk/offline-qr-code/issues/35#issuecomment-486770422:

Second, I didn't even realize but there are 3 options for the size. I think that instead of asking the user, it should just do it automatically:

• overflow menu: fill available area
• mobile screen: fill screen [with some padding]
• popup: remember the last size

So this would result in the removal of three size options and trying to "intelligently" do what the user might want.

This would also:

• remove the way to statically define a fixed size of the QR code
• removal of the option to not remember the QR code size

Analysis of places

Actually, I see it's kinda hard, because the add-on can appear in many places with different restrictions:

Place	height	width	does remembering size make sense?
popup	resizable (with max)	resizable (with max)	yes
overflow	resizable (with max)	fixed	no?
mobile screen	fixed	fixed (and small!)	no
tablet screen	fixed	fixed	yes?

The last column is a hard one, because it's already subjective, but actually, we might even have to remember different sizes, based on whether it is a tablet screen or not…

Questions

• What use cases could be destroyed when we remove it?
• Do users actually care/need the three size options or are they really redundant?
• On fixed size "screens" (mobile + overflow) should there still be a resize button?
• If we take https://github.com/rugk/offline-qr-code/issues/90 into account, we would need to have a way more "flexible" generation method for QR codes.

[rugk]

IMHO…

What use cases could be destroyed when we remove it?

• As a user, I might want to save my QR code in a fixed size.
• As a user, I might just not remember the QR code size, because I only have temporary bad conditions or so. (Personally, i sometimes just increase the size up to the limit then, but won't want to see this the next time I open it.)

[rugk]

So @bfred-it, what i also don't like about your idea is the big removal of all user options. I mean, as the use cases above show, such a "clever" add-on could sometimes not really be efficient for you.

So I'd suggest to possibly still have these options:

• [x] Automatically adjust size. [if not somehow offer current user the current pixel input]
• [x] Remember last size.

Note these are checkboxes, so you can check both, none or one at one time. (Both shall be enabled by default.) Both only apply on resizable QR code pages. If fixed sizes are there, we try to automatically determinate a good size.

What I like about these settings is that they are self-explanatory and do not need such a big explanation as the current ones.

IMHO these would satisfy the use cases presented here.

---

BTW, I hope you see, this is way harder than one might think… :wink:

[rugk]

Oh your avatar always fits… :stuck_out_tongue_winking_eye:

But no, it's not that simple. Again you dismiss two use cases and completely ignore things like https://github.com/rugk/offline-qr-code/issues/90. The correct implementation of this would be quite hard.