offline-qr-code
offline-qr-code copied to clipboard
rugk
Fix incorrect display of messages on multiple lines
Fixes #12
UI changes done for same.
@rugk attaching screenshots for Ui display on diff screen width.Please suggest any changes if needed
Hi @lazy-sunshine, thanks for your first contribution to this project! :tada: :+1: 🏅 I hope you'll like this project and enjoy hacking on it… :smiley:
I'll do a review soon and will later also test out the changes. But the screenshots look great/promising, already, thanks. :smiley:
Please do also note one important precautionary warning of me: In case you did not notice, you have committed (i.e. created commits) with potentially sensitive data like your (full/private) name or mail. Anyone, who clones your fork/this repo can view these private details, exactly as you've committed them. Also, if this PR gets merged, this will stay in the (commit) history of this project and will thus hard to be removed later.
So if this was unintentional and you want that data to be changed/removed first, better do it now. :smiley: Here is a good resource (actually from GitHubs help) on how to change your name/mail afterwards.
Also note that when setting your git username and especially your email, you can actually write/choose anything there. As for GitHub, it is recommend to use your GitHub username and – if you want to keep your mail private – the GitHub provided noreply address. You can even block pushes of commits with private mails.
So far just the possibilities. I just wanted to serve this as a friendly reminder, so you don't notice this only when it's too late. What you'll do depends solely on you. :smile:
@lazy-sunshine Are you still interested in completing this? If not, that's no problem, just add a notice, so I know what the current status of this PR is.
@lazy-sunshine Are you still interested in completing this? If not, that's no problem, just add a notice, so I know what the current status of this PR is.