human-essentials

human-essentials copied to clipboard

[BUG]: flaky `distributions_by_county_system_spec`

2

[This test](https://github.com/rubyforgood/human-essentials/blob/9258f16596f341466d7edf11a6373242e061989f/spec/system/distributions_by_county_system_spec.rb#L18) has order dependent failures on main. https://github.com/rubyforgood/human-essentials/actions/runs/8962284988/job/24610951378 Minimal reproduction command: ```console rspec ./spec/requests/account_requests_spec.rb[1:2:3:1,1:3:3:1] ./spec/requests/attachments_requests_spec.rb[1:1:1] ./spec/requests/distributions_requests_spec.rb[1:1:1:1,1:1:2:1,1:1:2:2:1,1:1:3:1,1:1:4:1,1:1:4:2,1:1:4:3,1:1:4:4:1,1:1:5:1,1:1:5:2,1:1:6:1,1:1:6:2:1,1:1:6:3:1,1:1:7:1,1:1:7:2,1:1:7:3:1,1:1:8:1,1:1:9:1:1,1:1:9:1:2,1:1:10:1,1:1:10:2,1:1:10:3,1:1:11:1,1:1:12:1,1:1:12:2:1,1:1:12:2:2,1:1:12:3:1,1:1:12:3:2:1,1:1:12:3:3:1,1:1:13:1,1:1:13:2,1:1:13:3,1:2:1,1:2:2:1:1] ./spec/requests/users_requests_spec.rb[1:1:1,1:2:1,1:3:1,1:3:2,1:3:3,1:3:4,1:4:1:1,1:4:1:2,1:4:2:1] ./spec/system/distributions_by_county_system_spec.rb[1:1:1,1:1:2] ./spec/system/request_system_spec.rb[1:1:1,1:1:2] --seed 48062 ``` Okay, I lied its not the minimal...

elasticspoon

Add optional signature line to distribution printout

4

# Summary Some (but not all) banks use the distribution printout as a receipt, requiring a signature from the partner on pickup or delivery. Add that at the end of...

cielf

[WIP] Partner::AGENCY_TYPES is an enum on Partners::Profile

1

Resolves #4241 ### Description This PR converts `Partner::AGENCY_TYPES` from a constant on partner to an enum on `Partners::Profile`. It introduces a new `agency_types_description` method which accesses the value stored in...

veezus

Super admin session poisoning after switching roles via dropdown

1

# Summary Fix problems when you are a superadmin and org user # Why Improves support capability # Details You should be able to switch back and forth between superadmin...

cielf

Resolves #001 ### Description ### Type of change * Bug fix (non-breaking change which fixes an issue) * New feature (non-breaking change which adds functionality) * Breaking change (fix or...

cancelei

Add Nix as a installation method

10

This works locally for me. I will be dog-fooding it for a bit. But I think its a nice additional method of setup with minimal work and dependencies. I also...

elasticspoon

Add a comment field to product drive participant

6

# Summary Add a comment field to the product drive participant # Why So the banks can keep some info about the person to refer to when contacting them for...

cielf

Change error message for "Quantity is not a number" to "Quantity is not a number -- note: commas are not allowed."

2

# Summary Provide more detail on "Quantity is not a number" error on Itemizables # Why? This error specifically excludes values like "1,300" -- the comma is not allowed. But...

cielf

[BUG] You can enter an issued_at date without a time. Hijinks ensue.

9

# Summary It is possible to enter an issued_at date without a time. If you do, the date is not properly saved. # Why investigate? Possible reduction of support issues....

cielf

Revamp specs to stop relying on seeded data

4

### Summary Currently, our specs create the following data before every single test: * Create 45 base items. * Create an organization with 45 items. * Create 4 org users....

dorner