human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Change error message for "Quantity is not a number" to "Quantity is not a number -- note: commas are not allowed."

Open cielf opened this issue 1 year ago • 2 comments

Summary

Provide more detail on "Quantity is not a number" error on Itemizables

Why?

This error specifically excludes values like "1,300" -- the comma is not allowed. But people who enter numbers with commas will expect them to be considered numbers. We need to explain better.

Details

Change the "Quantity is not a number" error on Itemizable to "Quantity is not a number . Note: commas are not allowed"

Criteria for completion

  • [ ] text changed
  • [ ] tests around quantity still work
  • [ ] please provide a screenshot of the error in action

cielf avatar Apr 28 '24 14:04 cielf

I'd like to take this if available!

mikjmcc26 avatar Apr 28 '24 15:04 mikjmcc26

It's yours!

cielf avatar Apr 29 '24 15:04 cielf

Can I pick this up?

vsrnth avatar May 23 '24 06:05 vsrnth

Yes!

dorner avatar May 23 '24 12:05 dorner

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jun 23 '24 00:06 github-actions[bot]