Ruben Vermeersch

First one is definitely not something we can change, even if we wanted to (I don't): compatibility matters! But you can work around this by setting a translation parameter: https://rocketeer.be/blog/2016/06/translate-params/...

Also, placeholders like {{1}} are horrible for translators as they have no semantic meaning. It helps translators massively to see {{username}}, replacing it with a number is a very bad...

@rdeslonde-eichleay I'd highly recommend you do not do that. Not all languages use the same word order so it might lead to very weird translations. Always put the full string...

``` $rootScope.message = 'welcome'; ``` Should be: ``` $rootScope.message = gettext('welcome'); ``` See https://angular-gettext.rocketeer.be/dev-guide/annotate-js/ But @mattbrunetti is 100% correct, your keys should *always* be the untranslated English strings, otherwise your...

Do you have an example of a jsFiddle that demonstrates this problem? There's no parsing happening in the code you're referencing, just a simple property loop.

Sadly, no. I'm afraid the commit log is your best friend.

@abruzzihraig I'm pretty sure that functionality works. Nonetheless, if we want to get this in, you'll need to add a unit test, which fails without the fix applied.

Note that we have a test that tests exactly this: https://github.com/rubenv/angular-gettext/blob/7d7ac672ad660eb3cba3366d76cb75cc4eef0979/test/unit/directive.js#L134-L143

> @rubenv why you don't extract the plural form from .po files? Instead you creating your gettextPlurals factory? Because we don't want to include a parser for arbitrary expressions (or...

@aprocom The convention when specifying locales in programming environments is an underscore, which you can verify by running `locale` on a unix machine: ``` $ locale LANG=en_US.UTF-8 LC_CTYPE="en_US.UTF-8" LC_NUMERIC="en_US.UTF-8" LC_TIME="en_US.UTF-8"...