Ruben Vermeersch

Results 194 comments of Ruben Vermeersch

It's not about whether a Makefile is handy, or that modules are new to me (don't make assumptions, they most certainly aren't). It's that they don't belong together in a...

Creating a database is something I always felt that it shouldn't have a place in sql-migrate: it'll make your application unportable because you're hardcoding connection details (in this case the...

Queries are split and executed one at a time. Perhaps our query parser does not recognize the copy correctly and only submits it partially? On Sat, Sep 7, 2019, 13:07...

It's been a long time since I touched this code, but I'm guessing this is caused by sqlparse (https://github.com/rubenv/sql-migrate/tree/master/sqlparse) not understanding function definitions. In a migration we need to split...

@Mama59 Could you add a unit test that demonstrates what goes wrong here and what it fixes?

Not sure which DB this is, but if it's PostgreSQL then there's nothing much we can do about that. DDL changes in PostgreSQL aren't transactional, so you can't roll them...

Create your database outside of sql-migrate. That's usually considered part of your infrastructure, not your app.

> Disagree database is part of the infrastructure. Maybe in 1980. But the ability to spin up arbitrary containers (databases OR tables) should be common for CI usage. Believe it...