Rúben Sousa

Results 42 comments of Rúben Sousa

The PR should be submitted against dev instead of master. I'll try to push this myself to dev tomorrow since I can't do it today. Sorry for taking too long...

Looks great to me, but I just have one question: why don't we just check if the icon exists inside the view holder? This way, we also allow showing items...

Did you find a solution for this?

My suggestion would be placing a View with the background you want and then hide/show it according to the bottom sheet's visibility. If you pass a CoordinatorLayout, there's no BottomSheetDialog,...

Ah, so you're reusing the same instance? I usually don't do this, so I didn't even think about it. I'll mark this as a bug and will fix it once...

There's no support for this, yet. Meanwhile you can use: ```java setItemBackground(@DrawableRes int background) ```

Hi, are you clicking in the button "Show view" to show the BottomSheet? If so, you're facing this issue: https://code.google.com/p/android/issues/detail?id=201825 To fix this, you need to drag the sheet before...

Hey @vahid-m All decorators use specific left/right values instead of start/end. Typically left/right means exactly that, it doesn't change depending on LTR or RTL. I could add support for start/end...

Did you check this? https://github.com/rubensousa/GravitySnapHelper/blob/master/gravitysnaphelper/src/main/java/com/github/rubensousa/gravitysnaphelper/GravityPagerSnapHelper.java

Can you upload a sample showcasing the issue? GravityPagerSnapHelper only works if you have the items with "match_parent", same as ViewPager