BottomSheetBuilder icon indicating copy to clipboard operation
BottomSheetBuilder copied to clipboard

[f] support set show icon or not, add menu icon without icon

Open luongvo opened this issue 7 years ago • 6 comments

This resolve #21

  • Create builder method addItem(int id, @StringRes int title) and addItem(int id, String title) to add menu without drawable icon
  • Create builder method setShowIcon(boolean showIcon) to enable or disable icon showing in menu item layout
  • Update example and readme

luongvo avatar Jan 16 '18 17:01 luongvo

Hi @rubensousa: Can you please review and merge this PR.

Thanks </ Pranav >

prscX avatar Jul 29 '18 12:07 prscX

The PR should be submitted against dev instead of master. I'll try to push this myself to dev tomorrow since I can't do it today. Sorry for taking too long to respond to this :/

rubensousa avatar Jul 29 '18 14:07 rubensousa

Thanks @rubensousa. Looking forward for a release.

Thanks, </ Pranav >

prscX avatar Jul 29 '18 15:07 prscX

@rubensousa @prscX just switched to dev instead of master, also resolved conflicts too, please review it. Thanks 🚀

luongvo avatar Jul 30 '18 04:07 luongvo

Looks great to me, but I just have one question: why don't we just check if the icon exists inside the view holder? This way, we also allow showing items with icons mixed with ones that don't have icons. Or maybe both: checking if the flag is true and checking if the icon exists to toggle the imageview visibility. What do you think?

This would also cover: https://github.com/rubensousa/BottomSheetBuilder/pull/32

rubensousa avatar Jul 30 '18 19:07 rubensousa

Any news on this?

eladgel avatar Nov 01 '18 18:11 eladgel