PyBaMM icon indicating copy to clipboard operation
PyBaMM copied to clipboard

Check coord_sys of SpatialVariable

Open rtimms opened this issue 3 years ago • 2 comments

When creating a SpatialVariable check the coordinate system against KNOWN_COORD_SYS defined here.

rtimms avatar Aug 09 '22 10:08 rtimms

You beat me hahaha. The docstring also needs fixing.

brosaplanella avatar Aug 09 '22 10:08 brosaplanella

Also, add a setter for coord_sys is SubMesh to perform this check for the meshes too.

rtimms avatar Aug 09 '22 10:08 rtimms

Is this solved by #3394 and #3114? This seems like a duplicate

kratman avatar May 03 '24 20:05 kratman

Yes, Ferran mentioned in https://github.com/pybamm-team/PyBaMM/issues/3114#issuecomment-1648160595 that #3394 should close both issues. We should probably close this one and keep the newer one open.

agriyakhetarpal avatar May 03 '24 21:05 agriyakhetarpal