Ryan Christian

Results 344 comments of Ryan Christian

> Are you able to give some context on the 'why' of that? I don't love bumping min Node to 18 so quickly. > Do you have a set of...

> I guess I tend to have a default to a perfectionist mindset of 'do it right' (which often leads to scope creep 😅) I'd hesitate to call that the...

> I was referring to here was more about updating the 2-3 year old build tooling to modern versions > > I'm somewhat interested to see what other benefits can...

> when updated Are you referring to HMR? Might be an issue for [Prefresh](https://github.com/preactjs/prefresh). Edit: Hmm, looks like it should be supported, per https://github.com/preactjs/preset-vite/pull/58

> Do you think I should recreate this issue on the Prefresh repo? Can just CC @JoviDeCroock here, he would know best I believe. I don't know where we broke...

Wouldn't this get quite tedious to constantly bump? My gut says this is better left as information for people to check while reviewing than a pass/fail action.

> If the threshold is set too low, then yes it would be tedious. Yeah, this is what I was referring to; I think it'd be quite difficult to have...

Superseded by #103 Thanks though

Going to close this on out, as Jovi and Jason mentioned, this seems like the wrong implementation. Per [react.dev](https://react.dev/reference/react/useInsertionEffect), the point of this API is to fire pretty early: >...

> @preact/signals, @preact/signals-react. @preact/signals-core, All of these libraries use client-side rendering. So, The App router won't be an approach to use such a feature. This is incorrect, you can use...