Ryan Christian

Results 344 comments of Ryan Christian

Just ran into this too. If you set `manifest: false`, this breaks `injectRegister` (in dev, anyhow). The docs state that `manifest: false` should only disable the automatic generation of a...

Oh I can do, sorry. Must've misread this issue when skimming.

Yes, I can confirm that. Works exactly as expected using the production build.

Duplicate of #164, for what it's worth.

`peerDeps` vs `deps` shouldn't make any difference in terms of module resolution, this is unlikely to fix #19. Their comment directing users to list plugins as `peerDeps` is likely in...

Could you provide a reproduction by any chance? I'm unable to reproduce this behavior. [Everything seems to be correct from my quick testing](https://esm.rschristian.dev/#Ly8gVHJ5aW5nIHRvIHJlcHJvZHVjZSBwcmVhY3QtcmVuZGVyLXRvLXN0cmluZyMyNjIKLy8gLS0tLS0tLS0tLS0tLS0tLQoKaW1wb3J0IHsgRnJhZ21lbnQsIGgsIHJlbmRlciB9IGZyb20gJ2h0dHBzOi8vY2RuLnNreXBhY2suZGV2L3ByZWFjdCc7CmltcG9ydCB7IHNoYWxsb3dSZW5kZXIgfSBmcm9tICdodHRwczovL2Nkbi5za3lwYWNrLmRldi9wcmVhY3QtcmVuZGVyLXRvLXN0cmluZyc7CmltcG9ydCB7IGh0bWwgfSBmcm9tICdodHRwczovL2Nkbi5za3lwYWNrLmRldi9odG0vcHJlYWN0L3N0YW5kYWxvbmUnOwoKY29uc3QgQ29tcG9uZW50WCA9ICgpID0+IGgoJ2gxJywgbnVsbCwgJ0hlbGxvIFdvcmxkIScpOwpjb25zdCByZXN1bHQgPSBzaGFsbG93UmVuZGVyKGgoRnJhZ21lbnQsIG51bGwsIGgoQ29tcG9uZW50WCkpKTsKCnJlbmRlcihodG1sYDxoMSBzdHlsZT0iY29sb3I6d2hpdGUiPiR7cmVzdWx0fTwvPmAsIGRvY3VtZW50LmJvZHkpOw==). JSX vs `h` calls (as the above...

Probably well addressed in #85, so closing

#85 probably addresses this reasonably, feel free to comment if there's something better we could land though

Eyeballing it, would say 3 is fine, 4 is probably not. This might be a considerable amount of work -- depending on new defaults, might have to do a fair...